Only require endpoint name to be available when detecting receiving endpoint details#4945
Closed
andreasohlund wants to merge 2 commits intomasterfrom
Closed
Only require endpoint name to be available when detecting receiving endpoint details#4945andreasohlund wants to merge 2 commits intomasterfrom
andreasohlund wants to merge 2 commits intomasterfrom
Conversation
a91e50e to
07c15a0
Compare
07c15a0 to
c0e73ee
Compare
Member
Author
|
Talking to @johnsimons I realized that even though the change is trivial more testing should be done and changes to the API considered. Raised the following to track this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lowers the bar further when it comes to importing failures into service control.